Turn on more Commander CLI tests by shadowspawn · Pull Request #116 · bombshell-dev/tab

shadowspawn · 2026-05-28T23:22:53Z

I was making changes to the Commander adapter when I noticed that most of the tests were disabled. I did some investigation and some of the problems were the example file used in the tests was not set up the same way as the other adapters.

This PR adds the dev command expected by the tests and turns on related tests.

The other skipped tests are because presumably API/implementation has changed, and custom handlers are not getting installed using old code. I'll have a go at those separately.

tab/examples/demo.commander.ts

Lines 62 to 104 in 532721c

    
           // Configure custom completions 
        
           for (const command of completion.commands.values()) { 
        
             if (command.value === 'lint') { 
        
               // Note: Direct handler assignment is not supported in the current API 
        
               // Custom completion logic would need to be implemented differently 
        
             } 
        
             for (const [option, config] of command.options.entries()) { 
        
               if (option === '--port') { 
        
                 config.handler = () => { 
        
                   return [ 
        
                     { value: '3000', description: 'Default port' }, 
        
                     { value: '8080', description: 'Alternative port' }, 
        
                   ]; 
        
                 }; 
        
               } 
        
               if (option === '--host') { 
        
                 config.handler = () => { 
        
                   return [ 
        
                     { value: 'localhost', description: 'Local development' }, 
        
                     { value: '0.0.0.0', description: 'All interfaces' }, 
        
                   ]; 
        
                 }; 
        
               } 
        
               if (option === '--mode') { 
        
                 config.handler = () => { 
        
                   return [ 
        
                     { value: 'development', description: 'Development mode' }, 
        
                     { value: 'production', description: 'Production mode' }, 
        
                     { value: 'test', description: 'Test mode' }, 
        
                   ]; 
        
                 }; 
        
               } 
        
               if (option === '--config') { 
        
                 config.handler = () => { 
        
                   return [ 
        
                     { value: 'config.json', description: 'JSON config file' }, 
        
                     { value: 'config.yaml', description: 'YAML config file' }, 
        
                   ]; 
        
                 }; 
        
               } 
        
             } 
        
           }

…s. Enable cli tests on Commander too.

changeset-bot · 2026-05-28T23:22:59Z

⚠️ No Changeset found

Latest commit: 7c9f37c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new · 2026-05-29T06:27:22Z

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tab@116

commit: 7c9f37c

AmirSa12 · 2026-05-29T06:28:37Z

Thanks! @shadowspawn
I remember opening #30 for that reason..
I appreciate your help on this, John!

AmirSa12

Thank you so much!!!

Modify example commander file to match others and what testing expect…

37b665a

…s. Enable cli tests on Commander too.

shadowspawn added 3 commits June 3, 2026 19:04

Reviewing Commander tests without refactoring anything yet

4d50985

Clarify comment

4b17ba3

Remove temporary comments/changes.

660dca6

shadowspawn changed the title ~~Turn on Commander CLI tests~~ Turn on more Commander CLI tests Jun 4, 2026

Reduce changes, restore non-functional code

7c9f37c

shadowspawn marked this pull request as ready for review June 5, 2026 04:04

shadowspawn mentioned this pull request Jun 5, 2026

Rework complete command for Commander #125

Open

AmirSa12 approved these changes Jun 5, 2026

View reviewed changes

AmirSa12 merged commit 47542e9 into bombshell-dev:main Jun 5, 2026
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Turn on more Commander CLI tests#116

Turn on more Commander CLI tests#116
AmirSa12 merged 5 commits into
bombshell-dev:mainfrom
shadowspawn:enable-more-commander-tests

shadowspawn commented May 28, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented May 28, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 29, 2026 •

edited

Loading

Uh oh!

AmirSa12 commented May 29, 2026 •

edited

Loading

Uh oh!

AmirSa12 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// Configure custom completions
	for (const command of completion.commands.values()) {
	if (command.value === 'lint') {
	// Note: Direct handler assignment is not supported in the current API
	// Custom completion logic would need to be implemented differently
	}

	for (const [option, config] of command.options.entries()) {
	if (option === '--port') {
	config.handler = () => {
	return [
	{ value: '3000', description: 'Default port' },
	{ value: '8080', description: 'Alternative port' },
	];
	};
	}
	if (option === '--host') {
	config.handler = () => {
	return [
	{ value: 'localhost', description: 'Local development' },
	{ value: '0.0.0.0', description: 'All interfaces' },
	];
	};
	}
	if (option === '--mode') {
	config.handler = () => {
	return [
	{ value: 'development', description: 'Development mode' },
	{ value: 'production', description: 'Production mode' },
	{ value: 'test', description: 'Test mode' },
	];
	};
	}
	if (option === '--config') {
	config.handler = () => {
	return [
	{ value: 'config.json', description: 'JSON config file' },
	{ value: 'config.yaml', description: 'YAML config file' },
	];
	};
	}
	}
	}

Uh oh!

Conversation

shadowspawn commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

pkg-pr-new Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmirSa12 commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmirSa12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shadowspawn commented May 28, 2026 •

edited

Loading

changeset-bot Bot commented May 28, 2026 •

edited

Loading

pkg-pr-new Bot commented May 29, 2026 •

edited

Loading

AmirSa12 commented May 29, 2026 •

edited

Loading